Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): clicking handle advances to the next breakpoint #25540

Merged
merged 22 commits into from
Jul 6, 2022

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Jun 27, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Clicking the sheet modal handles not advance to the next available breakpoint.

Issue URL: #24069

What is the new behavior?

  • Introduces handleBehavior, which controls if clicking the sheet modal handle advances to the next available breakpoint.
  • handleBehavior defaults to none, meaning that existing sheet modals will need to opt-in to this behavior.
  • Clicking the handle multiple times will ignore additional presses until the modal moves to the next breakpoint
  • While a breakpoint is transitioning, clicking the backdrop will not dismiss the modal.
  • When handleBehavior is cycle, the handle element will be focusable and include aria-labels informing "Activate to adjust the size of the dialog overlaying the screen".

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jun 27, 2022
@github-actions github-actions bot added the package: angular @ionic/angular package label Jun 27, 2022
@github-actions github-actions bot added the package: vue @ionic/vue package label Jun 27, 2022
@sean-perkins sean-perkins marked this pull request as ready for review June 27, 2022 19:08
@sean-perkins sean-perkins requested a review from a team as a code owner June 27, 2022 19:08
@liamdebeasi liamdebeasi self-requested a review June 30, 2022 13:33
core/src/components/modal/modal.tsx Outdated Show resolved Hide resolved
core/src/components/modal/modal.tsx Outdated Show resolved Hide resolved
core/src/components/modal/modal.tsx Outdated Show resolved Hide resolved
core/src/components/modal/modal.tsx Show resolved Hide resolved
@sean-perkins sean-perkins changed the base branch from main to feature-6.2 July 1, 2022 14:32
@github-actions github-actions bot added the package: react @ionic/react package label Jul 1, 2022
@github-actions github-actions bot removed the package: react @ionic/react package label Jul 1, 2022
core/src/components/modal/gestures/sheet.ts Outdated Show resolved Hide resolved
core/src/components/modal/modal.tsx Show resolved Hide resolved
core/src/components/modal/modal.tsx Show resolved Hide resolved
core/src/components/modal/modal.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just a few small things below.

core/src/components/modal/modal.tsx Outdated Show resolved Hide resolved
core/src/components/modal/modal.tsx Show resolved Hide resolved
core/src/components/modal/modal.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants