feat(datetime-button): add datetime button for displaying datetime in overlays #25655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: angular
|
Feel free to bikeshed APIs on this PR now that the implementation is complete. |
13 tasks
sean-perkins
changed the title
sean-perkins
requested changes
Jul 25, 2022
amandaejohnston
suggested changes
Jul 26, 2022
core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts
Outdated
Show resolved
Hide resolved
sean-perkins
approved these changes
Jul 26, 2022
amandaejohnston
approved these changes
Jul 26, 2022
This reverts commit 96fbd33.
|
The docs for |
|
They are not live yet. You can see a preview version here: ionic-team/ionic-docs#2464 |
|
@liamdebeasi Great, thank you |
This was referenced Aug 1, 2022
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL:
What is the new behavior?
ion-datetime-button, a component that renders the formatted date + time for an associated datetime instance. This component should be used when screen space is constrained and serves as a drop in replacement for the old v5 datetime component while also using the new datetime layout.Does this introduce a breaking change?
Other information