Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): go back to correct view with memory history #25732

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Aug 5, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25705

The current check did not account for tab values that are undefined initially. As a result, the code was getting pushed into a block that should be only run when in tabs. We should clean this up in the future and converge on either '' or undefined, but for now we can account for both with a false-y check.

What is the new behavior?

  • Ionic Vue Router correctly checks to see if a page is/is not in tabs.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: angular @ionic/angular package package: vue @ionic/vue package labels Aug 5, 2022
@github-actions github-actions bot removed the package: angular @ionic/angular package label Aug 5, 2022
@liamdebeasi liamdebeasi changed the title Fw 1981 fix(vue-router): go back to correct view with memory history Aug 5, 2022
@liamdebeasi liamdebeasi changed the title fix(vue-router): go back to correct view with memory history fix(vue): go back to correct view with memory history Aug 5, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review August 5, 2022 19:18
@liamdebeasi liamdebeasi requested a review from a team as a code owner August 5, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: vue, incorrectly routes back when tab is undefined
2 participants