Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(item): remove delegatesFocus patch for iOS 13 #25822

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Aug 25, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25273

iOS 13 required a delegatesFocus patch to be added due to this WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=214859

Ionic 7 only supports iOS 14+, so this patch is no longer needed. It was also interfering with non-iOS platforms (see linked issue). This proposed change is also needed for #18532.

What is the new behavior?

  • DelegatesFocus patch for iOS 13 has been removed.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: core @ionic/core package package: vue @ionic/vue package labels Aug 25, 2022
@liamdebeasi liamdebeasi changed the base branch from main to feature-7.0 August 25, 2022 13:39
@liamdebeasi liamdebeasi marked this pull request as ready for review August 25, 2022 14:13
@liamdebeasi liamdebeasi requested a review from a team as a code owner August 25, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: delegatesFocus patch for ios causes rendering issues with item sliding in chrome
2 participants