Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): custom animation plays when replacing #25863

Merged
merged 12 commits into from
Sep 6, 2022
Merged

fix(vue): custom animation plays when replacing #25863

merged 12 commits into from
Sep 6, 2022

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25831

By default, a replace operation should not play an animation. We accomplish this by setting the duration to 0 when calling IonRouterOutlet.commit. However, we should play an animation if a developer has explicitly passed a custom animation. Right now we do not, so all custom animations appear to not play.

I also found that a test in hooks.spec.ts was testing the wrong behavior, even though useIonRouter states in the docs that you can pass a custom animation when doing useIonRouter().replace(...): https://ionicframework.com/docs/vue/utility-functions#interfaces

What is the new behavior?

  • IonRouterOutlet now respects custom animations even when performing a replace operation.
  • Fix incorrect test in hooks.sepc.ts

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: vue @ionic/vue package label Aug 31, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review August 31, 2022 19:27
@liamdebeasi liamdebeasi requested a review from a team as a code owner August 31, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: useIonRouter doesn't use animation on replace
3 participants