feat(slides): remove ion-slide, ion-slides, and IonicSwiper module #25868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: angular
sean-perkins
reviewed
Sep 1, 2022
liamdebeasi
reviewed
Sep 1, 2022
There was a problem hiding this comment.
What do you think about removing slides.ios.vars.scss and inlining the values for each CSS var in https://github.com/ionic-team/ionic-framework/blob/main/core/src/css/ionic-swiper.scss? Now that the slides component is removed, having the disconnect between the two files feels strange.
sean-perkins
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ion-slide,ion-slides, and theIonicSwipermodule are all deprecated and slated for removal in Ionic v7.Issue URL: N/A
What is the new behavior?
Removes
ion-slide,ion-slides, and theIonicSwipermodule, as well as all references to them.Some slider/swiper-related files have been kept, namely ones that are used by the
IonicSlidesmodule or referenced in the Swiper.js migration docs.Does this introduce a breaking change?
Developers using these components will need to migrate to using Swiper.js directly, optionally using the
IonicSlidesmodule. Guides for migration and usage:Other information
Corresponding docs PR: ionic-team/ionic-docs#2518