feat(accordion): ionChange will only emit from user committed changes #25922
Conversation
github-actions
bot
added
package: angular
| @@ -31,7 +31,10 @@ export class IonAccordion { | |||
| import type { AccordionGroupChangeEventDetail as IAccordionGroupAccordionGroupChangeEventDetail } from '@ionic/core'; | |||
| export declare interface IonAccordionGroup extends Components.IonAccordionGroup { | |||
| /** | |||
| * Emitted when the value property has changed. | |||
| * Emitted when the value property has changed | |||
There was a problem hiding this comment.
This was auto-generated. The formatting looks weird, but should be fine?
There was a problem hiding this comment.
Yeah this should be fine. Intellisense still formats the text correctly. Just a quirk of the output target generator (we would have to split on line breaks and generate per line - which is possible, but the raw output works as is for now).
| @@ -31,7 +31,10 @@ export class IonAccordion { | |||
| import type { AccordionGroupChangeEventDetail as IAccordionGroupAccordionGroupChangeEventDetail } from '@ionic/core'; | |||
| export declare interface IonAccordionGroup extends Components.IonAccordionGroup { | |||
| /** | |||
| * Emitted when the value property has changed. | |||
| * Emitted when the value property has changed | |||
There was a problem hiding this comment.
Yeah this should be fine. Intellisense still formats the text correctly. Just a quirk of the output target generator (we would have to split on line breaks and generate per line - which is possible, but the raw output works as is for now).
|
Holding on review until tests are passing; seeing a bunch of random failures 🤔 Not sure what's going on there. |
|
Good to review now. There were some issues with installing dependencies for Playwright. Possibly related to https://www.githubstatus.com/incidents/8blgv351d71j. |
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: N/A Internal ticket
What is the new behavior?
ionChangewill now fire as a result of user-generated actions only.valueto be the first item in the array and re-emitionChange.Does this introduce a breaking change?
ionChangewill no longer be emitted when thevalueofion-accordion-groupis modified externally.ionChangewill only be emitted from user committed changes, such as clicking or tapping the accordion header.Other information