feat(checkbox): ionChange fires on user interaction #25923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: angular
liamdebeasi
changed the title
liamdebeasi
commented
Sep 12, 2022
| @@ -176,6 +188,7 @@ export class Checkbox implements ComponentInterface { | |||
| aria-checked={`${checked}`} | |||
| disabled={disabled} | |||
| id={inputId} | |||
| onChange={this.toggleChecked} | |||
There was a problem hiding this comment.
Open to keeping this as an onClick listener. I did not see any noticeable differences, but using onChange may make the standalone form component change a bit easier for ion-checkbox.
amandaejohnston
approved these changes
Sep 13, 2022
sean-perkins
approved these changes
Sep 13, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: N/A internal ticket
What is the new behavior?
ion-checkboxnow emitsionChangewhenever the nativechangeevent fires on<input type="checkbox" />.Does this introduce a breaking change?
ionChangeis no longer emitted when thecheckedproperty ofion-checkboxis modified externally.ionChangeis only emitted from user committed changes, such as clicking or tapping the checkbox.Other information