fix(input): clearOnEdit clears input when user initially types #26005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
commented
Sep 23, 2022
| @@ -432,37 +434,17 @@ export class Input implements ComponentInterface { | |||
| this.isComposing = false; | |||
| }; | |||
|
|
|||
| private clearTextInput = (ev?: Event) => { | |||
| private onClearButtonClick = (ev?: Event) => { | |||
There was a problem hiding this comment.
Renamed this function as it is the click handler for the button and should not be re-used directly by other parts of the implementation.
Instead if inner behavior needs to be shared, there should be another private function that both implementations call.
| * Otherwise the value will not be cleared | ||
| * if user is inside the input | ||
| */ | ||
| if (this.nativeInput) { |
There was a problem hiding this comment.
This change was made 3 years ago. I am unable to replicate the original bug: #17055 with this removed.
sean-perkins
commented
Sep 23, 2022
13 tasks
| * Clear the input if the control has not been previously cleared during focus. | ||
| * Do not clear if the user hitting enter to submit a form. | ||
| */ | ||
| if (!this.didInputClearOnEdit && this.hasValue() && ev.key !== 'Enter') { |
There was a problem hiding this comment.
This causes the value to be cleared when pressing keys like Ctrl and Shift that don't actually "type" anything. Not sure whether that's desired behavior.
13 tasks
|
Ok, this PR is updated to align with the conversations we had on the textarea |
amandaejohnston
approved these changes
Oct 10, 2022
liamdebeasi
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The
ion-inputfield does not initially clear whenclearOnEditis enabled, with a default value, when the control is first focused and modified.ionInputcan emit an detail ofundefined.Issue URL: Internal
What is the new behavior?
ion-inputwithclearOnEditenabled will clear the input when the control receives focus and is modifiedionInputcorrectly emits the parent event as the detail.Does this introduce a breaking change?
Other information