Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toggle): ionChange will only emit from user committed changes #26078

Merged
merged 6 commits into from
Oct 10, 2022

Conversation

amandaejohnston
Copy link
Contributor

@amandaejohnston amandaejohnston commented Oct 5, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

ion-toggle will emit an ionChange event if the value of the checked property is changed programmatically.

Issue URL: N/A

What is the new behavior?

ionChange is now only emitted from the user clicking or dragging the handle to toggle it.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package labels Oct 5, 2022
@amandaejohnston amandaejohnston marked this pull request as ready for review October 5, 2022 17:59
@amandaejohnston amandaejohnston requested a review from a team as a code owner October 5, 2022 17:59
core/src/components/toggle/toggle.tsx Outdated Show resolved Hide resolved
Co-authored-by: Sean Perkins <sean@ionic.io>
@amandaejohnston amandaejohnston merged commit 85d3bd9 into feature-7.0 Oct 10, 2022
@amandaejohnston amandaejohnston deleted the FW-2203 branch October 10, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants