Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: dependency to @ionic/core #26137

Closed
4 of 7 tasks
TiBz0u opened this issue Oct 14, 2022 · 6 comments · Fixed by #26148
Closed
4 of 7 tasks

bug: dependency to @ionic/core #26137

TiBz0u opened this issue Oct 14, 2022 · 6 comments · Fixed by #26148
Labels

Comments

@TiBz0u
Copy link

TiBz0u commented Oct 14, 2022

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x
  • Nightly

Current Behavior

Hi,
We discover, due to the lot of fixes on the ion-datetime component (thanks by the way), that the @ionic/angular package depends on the @ionic/core version with a ^ (Compatible with version).

Due to this, even if we choose a specific version of the @ionic/angular, it will automatically download the last version of the @ionic/core package that contains all the components and thus the fix/new behavior.

Expected Behavior

@ionic/angular and @ionic/core use the same version or approximately equivalent version (~)

Steps to Reproduce

ionic start myApp tabs

Code Reproduction URL

No response

Ionic Info

Ionic:

Ionic CLI : 6.18.1 (/Users/mainsys/.nvm/versions/node/v12.22.6/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 6.3.1
@angular-devkit/build-angular : 14.2.6
@angular-devkit/schematics : 14.2.6
@angular/cli : 14.2.6
@ionic/angular-toolkit : 6.1.0

Capacitor:

Capacitor CLI : 4.3.0
@capacitor/android : not installed
@capacitor/core : 4.3.0
@capacitor/ios : not installed

Utility:

cordova-res (update available: 0.15.4) : 0.14.0
native-run : 1.7.1

System:

NodeJS : v12.22.6 (/Users/mainsys/.nvm/versions/node/v12.22.6/bin/node)
npm : 6.14.15
OS : macOS Catalina

Additional Information

No response

@liamdebeasi
Copy link
Contributor

Thanks! This should be fixed in an upcoming release of Ionic. I changed it so that the same version of Ionic is always installed. This means that if you install @ionic/angular@6.3.0, then @ionic/core@6.3.0 will be installed.

@liamdebeasi liamdebeasi removed their assignment Oct 17, 2022
@TiBz0u
Copy link
Author

TiBz0u commented Oct 18, 2022

Thanks @liamdebeasi. I suppose this change is not retroactive. Package already shipped will have the old behavior.

@liamdebeasi
Copy link
Contributor

Correct, this fix will apply starting in Ionic 6.3.3.

@TiBz0u
Copy link
Author

TiBz0u commented Nov 19, 2022

Hi @liamdebeasi, by testing issue #26146 on stackblitz, I discover that your correction regarding this bug in Changelog 6.3.3 has disappeared...

Below the dependency when installing Ionic 6.3.6

  "dependencies": {
    "@ionic/core": "^6.3.6",
    "jsonc-parser": "^3.0.0",
    "tslib": "^2.0.0"
  }

=> 6.3.7 and thus, cannot test the bug on stackblitz anymore.

EDIT : In fact, by checking package.json file by tag, this problem has never been fixed. Even in 6.3.3 release, there is still a caret (^) on @ionic/core.

Kr.

@liamdebeasi
Copy link
Contributor

This PR should fix it: #26349

The original PR was wrong in that I only applied the result of lerna version --exact instead of having our release process run lerna version --exact. The new PR fixes that.

@ionitron-bot
Copy link

ionitron-bot bot commented Dec 23, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants