Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action-sheet): use action sheet overlay inline #26172

Merged
merged 10 commits into from
Nov 2, 2022
Merged

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

ActionSheet cannot be used as inline overlay. Developers must use a controller to present the overlay.

Issue URL: Internal

What is the new behavior?

  • ActionSheet supports isOpen and trigger for presenting the overlay
  • ActionSheet can be used as an inline overlay

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package labels Oct 26, 2022
@sean-perkins sean-perkins marked this pull request as ready for review October 26, 2022 18:30
@sean-perkins sean-perkins requested a review from a team as a code owner October 26, 2022 18:30
@amandaejohnston amandaejohnston requested a review from a team October 28, 2022 14:47
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@sean-perkins sean-perkins merged commit 92b763a into feature-7.0 Nov 2, 2022
@sean-perkins sean-perkins deleted the FW-2332 branch November 2, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants