Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: web-types are not generated for @ionic/vue #26198

Closed
4 of 7 tasks
TechAkayy opened this issue Nov 1, 2022 · 4 comments
Closed
4 of 7 tasks

bug: web-types are not generated for @ionic/vue #26198

TechAkayy opened this issue Nov 1, 2022 · 4 comments
Labels
package: vue @ionic/vue package type: bug a confirmed bug report

Comments

@TechAkayy
Copy link

TechAkayy commented Nov 1, 2022

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x
  • Nightly

Current Behavior

@ionic/vue/dist/web-types.json is empty and not generated correctly using script under ./scripts/build-web-types.js

This line is looking for a usage flag for vue and is skipping all components - https://github.com/ionic-team/ionic-framework/blob/main/packages/vue/scripts/build-web-types.js#L8

Expected Behavior

@ionic/vue/dist/web-types.json should contain all the components and their meta-data and get auto-generated correctly using script under ./scripts/build-web-types.js

Steps to Reproduce

Scaffold a new ionic cli based vue project (or) use Aaron's github repo from here - https://github.com/aaronksaunders/ionicv6-beta-vue-vite-project

npm install

Check node_modules/@ionic/vue/dist/web-types.json

Code Reproduction URL

https://github.com/aaronksaunders/ionicv6-beta-vue-vite-project

Ionic Info

Ionic:

Ionic CLI : 6.20.3 (/usr/local/lib/node_modules/@ionic/cli)

Capacitor:

Capacitor CLI : 4.0.1
@capacitor/android : 4.0.1
@capacitor/core : 4.0.1
@capacitor/ios : 4.0.1

Utility:

cordova-res : not installed globally
native-run (update available: 1.7.1) : 1.6.0

System:

NodeJS : v16.17.1 (/usr/local/bin/node)
npm : 8.15.0
OS : macOS

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Nov 1, 2022
@sean-perkins sean-perkins added package: vue @ionic/vue package type: bug a confirmed bug report labels Nov 1, 2022
@ionitron-bot ionitron-bot bot removed the triage label Nov 1, 2022
@sean-perkins
Copy link
Contributor

@TechAkayy thank you for reporting this issue!

I'll look into this further. The usage flag is no longer being generated in the docs.json file that that script runs off of. I'll see why that is the case and find a consistent way of generating those types moving forward.

@sean-perkins
Copy link
Contributor

This issue has been resolved and will be available in the nightly build of Ionic as well as the next patch release (6.3.5). Thank you again for reporting this!

@TechAkayy
Copy link
Author

Thanks bunch :-)

@ionitron-bot
Copy link

ionitron-bot bot commented Dec 3, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: vue @ionic/vue package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants