Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): generate web-types for components #26205

Merged
merged 4 commits into from
Nov 2, 2022
Merged

fix(vue): generate web-types for components #26205

merged 4 commits into from
Nov 2, 2022

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When moving the docs and usage examples out of the ionic-framework repository to ionic-docs, the script that generates web-types for Vue broke. It no longer had the .usage.vue property in the generated docs.json, resulting in no component types being generated.

Issue URL: #26198

What is the new behavior?

  • Web-types are generated for all components, unless manually excluded in the excludeComponents array (within the script file for now)
    • Excluded components are loosely based on the components that did not generate web-types in 5.6.x

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: vue @ionic/vue package label Nov 1, 2022
@sean-perkins sean-perkins marked this pull request as ready for review November 1, 2022 16:19
@sean-perkins sean-perkins requested a review from a team as a code owner November 1, 2022 16:19
@sean-perkins sean-perkins merged commit 1f7fc8f into main Nov 2, 2022
@sean-perkins sean-perkins deleted the FW-2715 branch November 2, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants