feat(input): component can be used outside of ion-item #26283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: angular
liamdebeasi
changed the title
sean-perkins
approved these changes
Nov 14, 2022
amandaejohnston
approved these changes
Nov 15, 2022
|
This is awesome! QQ: Is it planned to support icon's somehow as well? For example this are two inputs from our app right now:
|
|
We don't have that in the scope right now, but we would be open to adding it. |
|
should i wait for the beta until i create feat request issue? 🤔 |
|
You can create one now 👍 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Docs will be coming in a separate PR.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #20153 resolves #19084 resolves #22736
See #25661
What is the new behavior?
ion-inputcan now be used independent ofion-item.counter,counterFormatter,fill, andshapeproperties onion-itemhelperanderrorslots onion-item.Note: Each commit links back to a PR that describes the different functionality added. I opted to do this instead of adding all the changes directly into this branch.
Does this introduce a breaking change?
Other information