Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert): add ability to use alert inline #26316

Merged
merged 7 commits into from
Nov 18, 2022
Merged

Conversation

amandaejohnston
Copy link
Contributor

@amandaejohnston amandaejohnston commented Nov 17, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Alert can only be presented through alertController.

Issue URL: N/A

What is the new behavior?

  • Alert can now be used as an inline component, with support for both isOpen and trigger.
  • The .ion-delegate-host wrapper element for inline overlays is now only added for ion-modal and ion-popover, in order to fix an issue where the alert would appear underneath the backdrop.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 6.3.7-dev.11668790733.16ac6270

@github-actions github-actions bot added package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package labels Nov 17, 2022
@amandaejohnston amandaejohnston marked this pull request as ready for review November 17, 2022 21:50
@amandaejohnston amandaejohnston requested a review from a team as a code owner November 17, 2022 21:50
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The position: relative change is concerning, but it looks like this is due to the ion-delegate-host bug. Once that is resolved we should be able to remove position: relative. Looks great otherwise!

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@amandaejohnston
Copy link
Contributor Author

After talking on Slack, I've patched the ion-delegate-host element to only be added for modals and popovers, and reverted the patches to the alert CSS and a11y test. I also added a dev build to the bottom of the PR description. 👍

@amandaejohnston amandaejohnston merged commit 08c0a55 into feature-7.0 Nov 18, 2022
@amandaejohnston amandaejohnston deleted the FW-2333 branch November 18, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants