-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alert): add ability to use alert inline #26316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The position: relative
change is concerning, but it looks like this is due to the ion-delegate-host
bug. Once that is resolved we should be able to remove position: relative
. Looks great otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
After talking on Slack, I've patched the |
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Alert can only be presented through
alertController
.Issue URL: N/A
What is the new behavior?
isOpen
andtrigger
..ion-delegate-host
wrapper element for inline overlays is now only added forion-modal
andion-popover
, in order to fix an issue where the alert would appear underneath the backdrop.Does this introduce a breaking change?
Other information
Dev build:
6.3.7-dev.11668790733.16ac6270