Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): inline overlays are exported #26333

Merged
merged 6 commits into from
Nov 22, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 22, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

During IonPicker inline development I noticed that the Angular components for the other inline overlays were not exported.

What is the new behavior?

  • Angular components are now generated for inline overlays
  • The e2e apps now test inline overlays

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi changed the title Inline angular fix(angular): inline overlays are exported Nov 22, 2022
@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package labels Nov 22, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 22, 2022 15:58
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 22, 2022 15:58
@liamdebeasi liamdebeasi merged commit f23fb34 into feature-7.0 Nov 22, 2022
@liamdebeasi liamdebeasi deleted the inline-angular branch November 22, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants