Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(picker): add ability to use picker inline #26336

Merged
merged 18 commits into from
Nov 22, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 22, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: N/A
Picker can only be presented through pickerController.

What is the new behavior?

  • Picker can now be used as an inline component, with support for both isOpen and trigger.
  • Also fixes an issue unique to inline pickers where the selected item did not receive the selected class when the picker is re-opened.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package labels Nov 22, 2022
@liamdebeasi liamdebeasi changed the title Fw 2335 feat(picker): add ability to use picker inline Nov 22, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 22, 2022 16:37
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 22, 2022 16:37
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides a few copy & paste comments. Will need to rebuild once those changes are in.

core/src/components/picker/picker.tsx Outdated Show resolved Hide resolved
core/src/components/picker/picker.tsx Outdated Show resolved Hide resolved
core/src/components/picker/picker.tsx Outdated Show resolved Hide resolved
liamdebeasi and others added 5 commits November 22, 2022 13:44
@liamdebeasi
Copy link
Contributor Author

Need to merge #26333 first so I can add tests for inline picker

@github-actions github-actions bot added the package: angular @ionic/angular package label Nov 22, 2022
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@liamdebeasi liamdebeasi merged commit c0a8501 into feature-7.0 Nov 22, 2022
@liamdebeasi liamdebeasi deleted the FW-2335 branch November 22, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants