-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(picker): add ability to use picker inline #26336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides a few copy & paste comments. Will need to rebuild once those changes are in.
Co-authored-by: Sean Perkins <sean@ionic.io>
Co-authored-by: Sean Perkins <sean@ionic.io>
Co-authored-by: Sean Perkins <sean@ionic.io>
Need to merge #26333 first so I can add tests for inline picker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: N/A
Picker can only be presented through
pickerController
.What is the new behavior?
isOpen
andtrigger
.Does this introduce a breaking change?
Other information