Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): null values are not converted to falsy value #26341

Merged
merged 15 commits into from
Nov 23, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 22, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

null values for form components have been converted to '' for years in Angular. This has resulted in confusing developer experiences such as #26116. It appears that this change was originally made to better support IE9, so it should be safe to remove.

What is the new behavior?

  • null is no longer converted to the empty string in Ionic Angular apps.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package labels Nov 22, 2022
@liamdebeasi liamdebeasi changed the title fix(angular): null values are not converted to ‘’ fix(angular): null values are not converted to empty string Nov 22, 2022
@liamdebeasi liamdebeasi changed the title fix(angular): null values are not converted to empty string fix(angular): null values are not converted to falsy value Nov 22, 2022
BREAKING.md Outdated Show resolved Hide resolved
@liamdebeasi liamdebeasi marked this pull request as ready for review November 23, 2022 15:49
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 23, 2022 15:49
@liamdebeasi liamdebeasi merged commit ce2e37b into feature-7.0 Nov 23, 2022
@liamdebeasi liamdebeasi deleted the FW-2646 branch November 23, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants