Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input, toggle): add escape hatch property #26416

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Dec 5, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There is no escape hatch for Ionic's automatic opt-in behavior for the modern form markup. Since the opt-in logic is not perfect, there may be instances of components that are opted-in when developers are not ready to adopt the new markup.

What is the new behavior?

  • Adds a legacy property to both ion-input and ion-toggle. When true, the component will always use the legacy form markup.

A couple notes:

  1. This will be removed in an upcoming major release of Ionic.
  2. The escape hatch for the remaining form controls will be done in their respective feature PRs.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package labels Dec 5, 2022
@liamdebeasi liamdebeasi changed the title feat(many): add escape hatch property feat(input, toggle): add escape hatch property Dec 5, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review December 5, 2022 18:25
@liamdebeasi liamdebeasi requested a review from a team as a code owner December 5, 2022 18:25
@liamdebeasi liamdebeasi merged commit 1278a29 into feature-7.0 Dec 5, 2022
@liamdebeasi liamdebeasi deleted the legacy-prop branch December 5, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants