Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checkbox): component can be used outside ion-item #26518

Merged
merged 17 commits into from
Jan 5, 2023
Merged

feat(checkbox): component can be used outside ion-item #26518

merged 17 commits into from
Jan 5, 2023

Conversation

amandaejohnston
Copy link
Contributor

@amandaejohnston amandaejohnston commented Dec 20, 2022 •
edited

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: N/A

What is the new behavior?

ion-checkbox can now be used outside ion-item, using the new default slot to specify a label.

This PR is a combination of the following:

See those individual descriptions for more details.

Does this introduce a breaking change?

  • Yes
  • No

The --background and --background-checked CSS properties have been renamed to --checkbox-background and --checkbox-background-checked respectively.

Other information

@amandaejohnston
feat(checkbox): add base structure for use outside ion-item (#26438)
14ff7b0 
* feat(checkbox): add basic styling and CSS vars for new syntax (#26460)

* feat(checkbox): add labelPlacement and justify props (#26467)

* feat(checkbox): fix rendering in ion-item with new syntax (#26471)
@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package labels Dec 20, 2022
@amandaejohnston amandaejohnston marked this pull request as ready for review December 20, 2022 20:11
liamdebeasi
liamdebeasi suggested changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a ticket and add any TODOs to the codebase so we know what to clean up when we remove the legacy checkbox?

core/src/components/checkbox/test/a11y/index.html Show resolved Hide resolved
core/src/components/checkbox/checkbox.scss Show resolved Hide resolved
core/src/components/checkbox/checkbox.scss Outdated Show resolved Hide resolved
core/src/components/checkbox/test/basic/checkbox.e2e.ts Outdated Show resolved Hide resolved
core/src/components/checkbox/test/basic/checkbox.e2e.ts Outdated Show resolved Hide resolved
core/src/components/checkbox/test/indeterminate/checkbox.e2e.ts Outdated Show resolved Hide resolved
liamdebeasi
liamdebeasi approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Will need to sync with feature-7.0 and re-generate screenshots too.

core/src/components/checkbox/test/item/index.html Outdated Show resolved Hide resolved
sean-perkins
sean-perkins approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! None of my comments are blocking.

core/src/components/checkbox/checkbox.scss Outdated Show resolved Hide resolved
core/src/components/checkbox/checkbox.scss Outdated Show resolved Hide resolved
core/src/components/checkbox/checkbox.tsx Outdated Show resolved Hide resolved
@amandaejohnston amandaejohnston merged commit 9d52e70 into feature-7.0 Jan 5, 2023
@amandaejohnston amandaejohnston deleted the FW-2594 branch January 5, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

@sean-perkins sean-perkins sean-perkins approved these changes

Assignees
No one assigned
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amandaejohnston @liamdebeasi @sean-perkins @Ionitron