Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Aria attributes are not reflected to ion-item in Vue #26538

Closed
pablo7798 opened this issue Dec 27, 2022 · 8 comments
Closed

bug: Aria attributes are not reflected to ion-item in Vue #26538

pablo7798 opened this issue Dec 27, 2022 · 8 comments
Labels
package: vue @ionic/vue package type: bug a confirmed bug report

Comments

@pablo7798
Copy link

    @DeyBo thanks for testing and confirming that problem. It would definitely help if I had assigned to the correct key!

Here is an updated dev-build that assigns to aria-label, not ariaLabel.

npm install @ionic/angular@6.2.10-dev.11664382391.15516e55 

Originally posted by @sean-perkins in #25885 (comment)

Hi @sean-perkins,

Im using "@ionic/vue": "^6.4.1", and still having the problem with aria-label on ion-item elements. Does this fix included on the vue version?

Thank you.

@ionitron-bot ionitron-bot bot added the holiday triage issues that were created during holiday period label Dec 27, 2022
@ionitron-bot
Copy link

ionitron-bot bot commented Dec 27, 2022

Thanks for the issue! This issue has been labeled as holiday triage. With the winter holidays quickly approaching, much of the Ionic Team will soon be taking time off. During this time, issue triaging and PR review will be delayed until the team begins to return. After this period, we will work to ensure that all new issues are properly triaged and that new PRs are reviewed. In the meantime, please read our Winter Holiday Triage Guide for information on how to ensure that your issue is triaged correctly. Thank you!

@sean-perkins
Copy link
Contributor

Hello @pablo7798 thanks for reporting this issue.

I've confirmed that there is an issue with our @ionic/vue component wrappers, where reflected aria attributes are not available properties to assign.

For example, this should be valid usage:

<ion-item aria-label="Hello world">
 
</ion-item>

We will capture this as a bug and prioritize in the backlog.

@sean-perkins sean-perkins changed the title bug: item and card buttons should inherit aria-label attribute - VUE 3 bug: Aria attributes are not reflected to ion-item in Vue Dec 27, 2022
@sean-perkins sean-perkins added package: vue @ionic/vue package type: bug a confirmed bug report labels Dec 27, 2022
@ionitron-bot ionitron-bot bot removed holiday triage issues that were created during holiday period labels Dec 27, 2022
@pablo7798
Copy link
Author

Hello @pablo7798 thanks for reporting this issue.

I've confirmed that there is an issue with our @ionic/vue component wrappers, where reflected aria attributes are not available properties to assign.

For example, this should be valid usage:

<ion-item aria-label="Hello world">
 
</ion-item>

We will capture this as a bug and prioritize in the backlog.

Thank you @sean-perkins.

I was trying to use it like you say but never worked :(

@sean-perkins
Copy link
Contributor

Hello @pablo7798 can you test with this dev-build and let me know if you run into any issues?

npm install @ionic/vue@6.4.2-dev.11672266146.111c9c07 @ionic/vue-router@6.4.2-dev.11672266146.111c9c07

This is based on updates to the framework wrappers: ionic-team/stencil-ds-output-targets#316

@pablo7798
Copy link
Author

Hello @pablo7798 can you test with this dev-build and let me know if you run into any issues?

npm install @ionic/vue@6.4.2-dev.11672266146.111c9c07 @ionic/vue-router@6.4.2-dev.11672266146.111c9c07

This is based on updates to the framework wrappers: ionic-team/stencil-ds-output-targets#316

Hello @sean-perkins,

I have tested this build but the problem still there. I will try to explain it better:

In my case, the ion-item is transformed to a button, and there is where i want to put the aria-label attibute.

First, a capture of the original code fragment:
image

And here, the generated code:
image

I hope it's clearer, i am trying to make my site more accesible :)

@sean-perkins
Copy link
Contributor

Thank you for testing that dev-build and providing extra context @pablo7798!

Here is an updated version to test with:

npm install @ionic/vue@6.4.2-dev.11672338764.1def15a7

This should reflect the aria-label for both simple ion-item usages and when the ion-item is rendered as a button/clickable target. I've tested locally for both scenarios.

When installing the new version, I'd recommend deleting the node_modules/.cache/ directory, if it exists locally.

@pablo7798
Copy link
Author

Solved now! So thankful!

I have diferent problem with the ion-accordion, it generates a duplicated role attributes and dont provide aria-labels:

The code fragment is the same than on my last post, and here is the problem (green color, yellow ones are correct)

image

This might be on another thread, tell me if you prefer to start another one.

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 26, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: vue @ionic/vue package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants