Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item): inherit aria attributes before render #26546

Merged
merged 11 commits into from
Jan 27, 2023

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Dec 29, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The aria-label attribute is not reflected correctly with ion-item and Vue.

There are two contributing factors:

  1. The utility from @stencil/vue-output-target does not pass aria attributes from the Vue component host to the web component host.
  2. Attempting to reflect the aria attributes in a raf callback inside the componentDidLoad lifecycle would not reflect attributes correctly when rendering a link or button in ion-item.

Issue URL: #26538

What is the new behavior?

  • aria-label reflects from the ion-item to the .item-native element in Vue

Does this introduce a breaking change?

  • Yes
  • No

Other information

Note: Dependent on ionic-team/stencil-ds-output-targets#316 merging and a new build of the @stencil/vue-output-target.

Dev-build: 6.4.2-dev.11672338764.1def15a7

@github-actions github-actions bot added the package: core @ionic/core package label Dec 29, 2022
@github-actions github-actions bot added the package: vue @ionic/vue package label Jan 17, 2023
@sean-perkins sean-perkins marked this pull request as ready for review January 18, 2023 18:07
@sean-perkins sean-perkins requested review from a team and liamdebeasi as code owners January 18, 2023 18:07
@sean-perkins sean-perkins merged commit 95a3c69 into main Jan 27, 2023
@sean-perkins sean-perkins deleted the fix/vue-reflect-aria-attributes branch January 27, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants