-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): component can be used outside ion-item #26572
Conversation
feat(select): add label functionality
Run & review this pull request in StackBlitz Codeflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have examples/tests for the different interface appearances of ion-select
and the modern rendering?
The legacy tests show examples with interface="popover"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added tests. Will re-run screenshot jobs shortly. |
Good call out. The popover behavior has not changed, but since the select now contains the label, the popover is visually going to be centered within the line. IMO this is good because users can click anywhere on the line to open the popover. Thoughts? |
I think it should still appear on the end side, since that's where the actual select appears to be. Otherwise it can easily look like the popover is just opening under empty space, which is strange. IMO behavior should match with how the legacy select acts when placed within an item, since that's what it looks like, even when the new syntax isn't used with an item as well. |
Ok I fixed a handful of things:
Updating screenshots now and will re-request another review when that is done. |
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: Internal ticket
What is the new behavior?
ion-select
can now be used outside ofion-item
with a new property to specify the label.This PR is a combination of the following:
#26470
#26502
#26504
#26505
#26506
#26570
Does this introduce a breaking change?
Other information