Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radio): component can be used outside of ion-item #26582

Merged
merged 7 commits into from
Jan 11, 2023

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Jan 9, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

An ion-radio with a label, must be used inside of an ion-item.

e.g.:

<ion-radio-group>
  <ion-item>
    <ion-label>My label</ion-label>
    <ion-radio></ion-radio>
  </ion-item>
</ion-radio-group>

Issue URL: Internal

See: #25660

What is the new behavior?

ion-radio can now be used outside of ion-item, using the new default slot to specify a label.

e.g.:

<ion-radio-group>
  <ion-radio>My label</ion-radio>
</ion-radio-group>

This PR is a combination of the following:

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Jan 9, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package labels Jan 9, 2023
@sean-perkins sean-perkins marked this pull request as ready for review January 10, 2023 18:26
@sean-perkins sean-perkins requested review from a team and liamdebeasi as code owners January 10, 2023 18:26
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@sean-perkins sean-perkins merged commit 9761b0a into feature-7.0 Jan 11, 2023
@sean-perkins sean-perkins deleted the FW-2595 branch January 11, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants