feat(textarea): component can be used outside of ion-item #26674
Conversation
|
|
github-actions
bot
added
package: angular
sean-perkins
changed the title
|
In: http://localhost:3333/src/components/textarea/test/bottom-content the custom error color template has a different height than the other grid items. Edit: This was caused by an extra line break in the template: 6a55544 |
There was a problem hiding this comment.
These changes look good, though I see a few missing tests when compared with ion-input.
For reference, compare with the following files:
input/test/iteminput/test/statesinput/test/highlight
This is a combination of other PRs and is already big, so we should make these changes in a separate PR once this merges.
As an example, the highlight for success/invalid looks different than input
| textarea | input |
|---|---|
 |
 |
Additionally, setting disabled="true" does not change the opacity on the textarea.
However, these are minor bugs so I think we can merge this an then fix it in a separate PR. Great job with this!
|
I made the above changes in a separate PR here: #26676 Screenshots are running but then should be good for a review once that is done. |
|
I skipped the flaky select test. The test is being refactored in #26667. |
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: Internal
What is the new behavior?
ion-textareacan now be used independent ofion-item.Does this introduce a breaking change?
Other information