fix(vue): cache attached view reference

[sean-perkins]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Developers using Vue can run into an error when using an ion-select that presents a popover of options. The Vue delegate was incorrectly assuming that a component instance would always be passed as the argument to attachViewToDom.

This is not the case for ion-select, where a string of the tag name is used: https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/select/select.tsx#L414

Issue URL: #26643 (comment)
resolves #26695

What is the new behavior?

• Caches the reference to the created element, so the WeakMap always receives an object to that can be used for looking up and unmounting an overlay.
• Refactored the property to better signal that it can be an "object" (any) or a string. Note: Because any will overwrite the types, this does nothing from a typings perspective. This is just a visual signal to a developer.

Does this introduce a breaking change?

• Yes
• No

Other information

Repro: https://github.com/acoldfox/ionic-select-issue (you will need to install the dev-build to verify)

Dev-build: 6.5.2-dev.11674852369.1c9fe737

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[liamdebeasi]

We need a test for this. Also why does this issue not impact Ionic React?

[liamdebeasi]

Also be sure to note that this fixes #26695 when merging

[sean-perkins]

React only uses the framework delegate for IonNav. No other part of the implementation uses that logic. Vue on the other hand uses the framework delegate for any implementation that uses the createController approach (modal, popover, alert, action sheet, loading, picker and toast). This problem is unique to ion-select/ion-popover, in the way that ion-select passes a tag name as a string instead of a component instance to the attachViewToDom API.

I'll confirm #26695 today & fill in a test 👍

Edit: I misunderstood what issue was being linked to. I will reference that issue when merging, I need to also confirm the original intended fix behind this change against the dev-build.

[liamdebeasi]

Good to go once we have a test. Thanks for taking care of this!

[sean-perkins]

Ok - test case has been added.

Also confirmed against the original root issue: https://github.com/raymer/ionic-modal-bug that the expected behavior still occurs after this change.