Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update ionicons usage to v6.1.2 #26752

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 8, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: In order to fully resolve #26712, the version of ionicons used in Ionic needs to be updated to the latest version.

What is the new behavior?

  • Updates Ionicons to v6.1.2

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Feb 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package labels Feb 8, 2023
@liamdebeasi liamdebeasi changed the title chore(): add dev build fix(icon): update internal ionicon usage to v6.1.2 Feb 8, 2023
@liamdebeasi liamdebeasi changed the title fix(icon): update internal ionicon usage to v6.1.2 fix(deps): update ionicons usage to v6.1.2 Feb 8, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review February 8, 2023 14:22
@liamdebeasi liamdebeasi merged commit c07933c into main Feb 8, 2023
@liamdebeasi liamdebeasi deleted the update-ionicons-6-1-2 branch February 8, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ionicons md/ios props are not reactive
2 participants