feat(angular,angular-server): angular v14 minimum support #26822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ionic v7 targets a minimum of Angular 14. We no longer need to test these older targets of Angular.
This commit bumps the developer dependencies and peer dependencies to Angular 14. As a result, we need to update ng-packagr, which requires the `ng-package.json` configuration instead of the config living local to the `package.json`. The platform file change is a build-time error with the types, as a result of the typescript dependency version bump. There is a pending issue with the ng14 test app with this commit that I am digging into more and will fix in a follow-up commit.
Similar to earlier changes, the ng-packagr version bump requires that we split out the config into a separate file.
|
|
sean-perkins
changed the title
sean-perkins
changed the title
liamdebeasi
suggested changes
Feb 22, 2023
angular/test/apps/ng14/src/app/version-test/version-test-routing.module.ts
Show resolved
Hide resolved
liamdebeasi
approved these changes
Feb 22, 2023
|
Don't forget to update the commit description with the breaking change message too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: Internal
What is the new behavior?
Upgrades the
@ionic/angularand@ionic/angular-serverpackages to target a minimum supported version of Angular 14.@ionic/angularenvironmentInjectorproperties for standalone routing fromion-router-outletandion-tabs.ComponentFactoryResolverdeprecated usage has been migrated tocreateComponentorViewContainerRef, depending on the usage requirementinjectsyntax (aligning with the Angular team's convention)Test Infrastructure
ng12) and Angular 13 (ng13)Does this introduce a breaking change?
Other information