Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(searchbar): ionInput now emits value payload #26831

Merged
merged 13 commits into from
Feb 23, 2023
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 20, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #26828

The native change event can fire when "Enter" is pressed. Also, the ionInput payload on ion-searchbar is inconsistent with what is fired for ion-input and ion-textarea.

Design doc: https://github.com/ionic-team/ionic-framework-design-documents/blob/main/projects/ionic-framework/ionInput-payload/index.md

What is the new behavior?

  • Updates documentation to note "Enter" key
  • Updated ionInput payload to contain value and the event similar to ion-input and ion-textarea.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Feb 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package labels Feb 20, 2023
@liamdebeasi liamdebeasi changed the base branch from main to feature-7.0 February 20, 2023 20:32
@liamdebeasi liamdebeasi changed the title Fw 3523 feat(searchbar): ionInput now emits value payload Feb 20, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review February 21, 2023 18:58
@github-actions github-actions bot added package: react @ionic/react package package: vue @ionic/vue package labels Feb 22, 2023
@liamdebeasi
Copy link
Contributor Author

I forgot to export these interfaces from the JS Framework packages, so I addressed this in 2998468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-searchbar does not fire ionChange event on user input
3 participants