-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(searchbar): ionInput now emits value payload #26831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
github-actions
bot
added
package: angular
@ionic/angular package
package: core
@ionic/core package
labels
Feb 20, 2023
liamdebeasi
changed the title
Fw 3523
feat(searchbar): ionInput now emits value payload
Feb 20, 2023
sean-perkins
approved these changes
Feb 22, 2023
github-actions
bot
added
package: react
@ionic/react package
package: vue
@ionic/vue package
labels
Feb 22, 2023
I forgot to export these interfaces from the JS Framework packages, so I addressed this in 2998468 |
amandaejohnston
approved these changes
Feb 23, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: angular
@ionic/angular package
package: core
@ionic/core package
package: react
@ionic/react package
package: vue
@ionic/vue package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #26828
The native
change
event can fire when "Enter" is pressed. Also, theionInput
payload onion-searchbar
is inconsistent with what is fired forion-input
andion-textarea
.Design doc: https://github.com/ionic-team/ionic-framework-design-documents/blob/main/projects/ionic-framework/ionInput-payload/index.md
What is the new behavior?
ionInput
payload to contain value and the event similar toion-input
andion-textarea
.Does this introduce a breaking change?
Other information