Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): devs can import ionic/angular styles in css #26875

Merged
merged 5 commits into from
Feb 28, 2023

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

In beta.5 a regression was introduced that prevented developers from importing CSS files using the css-loader syntax for ~ based imports.

Issue URL: Internal

What is the new behavior?

  • Use the latest Angular package format syntax for exporting CSS files
  • Developers can import CSS with `~@ionic/angular/css/core.css

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Feb 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: angular @ionic/angular package label Feb 28, 2023
@sean-perkins sean-perkins marked this pull request as ready for review February 28, 2023 16:34
@liamdebeasi
Copy link
Contributor

Dev build: 7.0.0-dev.11677602162.14022a76

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a starter app, and this works great. Thanks for the quick turnaround on a fix!

@github-actions github-actions bot added package: react @ionic/react package package: vue @ionic/vue package labels Feb 28, 2023
@sean-perkins sean-perkins removed the request for review from amandaejohnston February 28, 2023 18:29
@sean-perkins sean-perkins merged commit 0d2fac2 into feature-7.0 Feb 28, 2023
@sean-perkins sean-perkins deleted the fix/angular-css-imports branch February 28, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants