fix(vue): input components update refs on ionInput #26876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #26700
The text input components are still listening on
ionChange
to update Vue refs. This means that refs are now only updated when the input is blurred due to the ionChange revisions in Ionic 7: https://github.com/ionic-team/ionic-framework/blob/feature-7.0/BREAKING.md#version-7x-inputWhat is the new behavior?
ionInput
to update any Vue refs instead ofionChange
ionInput
events to the internal kebab case events (v-ion-input
)Note: Only input, searchbar, and textarea have
ionInput
events so we can safely add this event case change without hard coding which components to apply this to.Dev build: 7.0.0-dev.11677608949.16e25264
Does this introduce a breaking change?
Other information