Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): input components update refs on ionInput #26876

Merged
merged 9 commits into from
Mar 2, 2023
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 28, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #26700

The text input components are still listening on ionChange to update Vue refs. This means that refs are now only updated when the input is blurred due to the ionChange revisions in Ionic 7: https://github.com/ionic-team/ionic-framework/blob/feature-7.0/BREAKING.md#version-7x-input

What is the new behavior?

  • Input, Searchbar, and Textarea now listen on ionInput to update any Vue refs instead of ionChange
  • The IonicVue plugin has been updated to convert ionInput events to the internal kebab case events (v-ion-input)
  • Added tests

Note: Only input, searchbar, and textarea have ionInput events so we can safely add this event case change without hard coding which components to apply this to.

Dev build: 7.0.0-dev.11677608949.16e25264

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Feb 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@liamdebeasi liamdebeasi changed the title Fw 3229 fix(vue): input components update refs on ionInput Feb 28, 2023
@github-actions github-actions bot added package: core @ionic/core package package: vue @ionic/vue package labels Feb 28, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review February 28, 2023 18:36
@liamdebeasi liamdebeasi requested a review from a team as a code owner February 28, 2023 18:36
@liamdebeasi liamdebeasi merged commit 7d9ce74 into feature-7.0 Mar 2, 2023
@liamdebeasi liamdebeasi deleted the FW-3229 branch March 2, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants