Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-datetime-button doesn't open ion-datetime modal #26916

Closed
4 of 8 tasks
de-dan opened this issue Mar 4, 2023 · 9 comments · Fixed by #26917
Closed
4 of 8 tasks

bug: ion-datetime-button doesn't open ion-datetime modal #26916

de-dan opened this issue Mar 4, 2023 · 9 comments · Fixed by #26917
Labels
package: angular @ionic/angular package type: bug a confirmed bug report

Comments

@de-dan
Copy link

de-dan commented Mar 4, 2023

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x
  • v7.x
  • Nightly

Current Behavior

When I click on ion-datetime-button, the darker overlay is shown, but no modal with datetime.

I use chrome 110.0.5481.77 on a Mac 13.2.1 but I have this bug reported from users with different OS's and browsers.
This problem occured after I upgraded to 6.6.0. Downgrading to 6.5.7 resolved the issue!

Expected Behavior

Show the modal when I click on date or time of ion-datetime-button.

Steps to Reproduce

Create a new ionic project
ionic start
I used the blank starter, angular

in home.page.html paste in the ion-datetime-button example from the docs

<ion-datetime-button datetime="datetime"></ion-datetime-button>

<ion-modal [keepContentsMounted]="true">
  <ng-template>
    <ion-datetime id="datetime"></ion-datetime>
  </ng-template>
</ion-modal>

Run it and click on the date or time. Only overlay is shown.

Code Reproduction URL

No response

Ionic Info

Ionic:

Ionic CLI : 6.20.8 (/usr/local/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 6.6.0
@angular-devkit/build-angular : 15.2.1
@angular-devkit/schematics : 15.2.1
@angular/cli : 15.2.1
@ionic/angular-toolkit : 8.0.0

Capacitor:

Capacitor CLI : 4.7.0
@capacitor/android : not installed
@capacitor/core : 4.7.0
@capacitor/ios : not installed

Utility:

cordova-res : 0.15.4
native-run : 1.7.2

System:

NodeJS : v18.14.2 (/usr/local/bin/node)
npm : 9.5.0
OS : macOS

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Mar 4, 2023
@dudynets
Copy link

dudynets commented Mar 5, 2023

I can confirm that the bug is present in version 7.0.0-rc.0 of the Ionic Framework, and is also reproducible in the StackBlitz sandbox from the official documentation.

screenshot_LQ9LyNjX

@liamdebeasi liamdebeasi self-assigned this Mar 6, 2023
@liamdebeasi
Copy link
Contributor

Thanks for the report. I can reproduce this. It looks the fix in 00d10f5 uncovered another bug with our modals. I'll take a closer look.

@liamdebeasi liamdebeasi added package: angular @ionic/angular package type: bug a confirmed bug report labels Mar 6, 2023
@ionitron-bot ionitron-bot bot removed the triage label Mar 6, 2023
@liamdebeasi
Copy link
Contributor

Here is a dev build if anyone is interested in testing the proposed fix:

npm install @ionic/angular@6.6.1-dev.11678112836.1733c8ec

@liamdebeasi liamdebeasi removed their assignment Mar 6, 2023
@dudynets
Copy link

dudynets commented Mar 6, 2023

Here is a dev build if anyone is interested in testing the proposed fix:

npm install @ionic/angular@6.6.1-dev.11678112836.1733c8ec

Everything works as expected, and the issue seems to have been resolved.

@vadimwe
Copy link

vadimwe commented Mar 6, 2023

I confirm issue.

`Ionic:

Ionic CLI : 6.20.8 (/opt/homebrew/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 6.6.0
@angular-devkit/build-angular : 15.2.1
@angular-devkit/schematics : 15.2.1
@angular/cli : 15.2.1
@ionic/angular-toolkit : 6.1.0

Capacitor:

Capacitor CLI : 4.7.0
@capacitor/android : 4.7.0
@capacitor/core : 4.7.0
@capacitor/ios : 4.7.0

Utility:

cordova-res : 0.15.4
native-run : 1.7.1

System:

NodeJS : v16.18.1 (/opt/homebrew/Cellar/node@16/16.18.1/bin/node)
npm : 8.19.2
OS : macOS
`

@moose4lord
Copy link

moose4lord commented Mar 6, 2023

I also ran into this issue when I upgraded to @ionic/angular 6.6.0.
The fix proposed by @liamdebeasi worked for me.
Thanks for looking into this and turning it around so quickly.

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #26917, and a fix will be available in an upcoming release of Ionic Framework.

@moose4lord
Copy link

I can confirm that this bug has been fixed in @ionic/angular 6.6.1.
Nice job guys!

@ionitron-bot
Copy link

ionitron-bot bot commented Apr 8, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: angular @ionic/angular package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants