Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(many): add aria-hidden to decorative icons #26922

Merged
merged 5 commits into from
Mar 7, 2023
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Mar 7, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Ionic Framework v7 still used Ionicons v6

I also noticed some issues with toast, reorder, and refresher-content where decorative icons were not hidden from assistive tech.

What is the new behavior?

  • Updates ionicons deps to v7.0.0
  • Adds aria-hidden="true" to the icons in refresher-content, reorder, and toast. (I am considering this a fix due to the aria-hidden changes here)

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Mar 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package labels Mar 7, 2023
@liamdebeasi liamdebeasi changed the title feat(deps): update to ionicons v7 chore(deps): update to ionicons v7 internally Mar 7, 2023
@liamdebeasi liamdebeasi changed the title chore(deps): update to ionicons v7 internally fix(deps): update to ionicons v7 internally Mar 7, 2023
@liamdebeasi liamdebeasi changed the title fix(deps): update to ionicons v7 internally fix(many): add aria-hidden to account for ionicons v7 Mar 7, 2023
@liamdebeasi liamdebeasi changed the title fix(many): add aria-hidden to account for ionicons v7 fix(many): add aria-hidden to decorative icons Mar 7, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review March 7, 2023 14:26
@liamdebeasi liamdebeasi merged commit 78303dc into feature-7.0 Mar 7, 2023
@liamdebeasi liamdebeasi deleted the FW-3621 branch March 7, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants