-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(breadcrumbs): color attribute shows on DOM for Vue #27068
Conversation
Run & review this pull request in StackBlitz Codeflow. |
4074fe2
to
fd3f879
Compare
Do not update this branch with main 🙂 |
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
fd3f879
to
fc56c2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
describe("Components: Breadcrumbs", () => { | ||
beforeEach(() => { | ||
cy.visit("http://localhost:8080/components/breadcrumbs"); | ||
}); | ||
|
||
it("should have color attribute", () => { | ||
cy.get('ion-breadcrumbs#color').should('have.prop', 'color'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to address this now since this is re-landing another approved PR, but it looks like other frameworks would benefit from this check. Should this be a check in core instead of just in the Vue test app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can move it over to core after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created FW-3889 to track and assigned to you @thetaPC 🚀
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL:
What is the new behavior?
Does this introduce a breaking change?
Other information