fix(vue): components have correct name in Vue Dev Tools #27180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
changed the title
liamdebeasi
changed the title
| @@ -16,6 +16,8 @@ export const IonApp = /*@__PURE__*/ defineComponent((_, { attrs, slots }) => { | |||
| }; | |||
| }); | |||
|
|
|||
| IonApp.name = "IonApp"; | |||
There was a problem hiding this comment.
I noticed that other components set the name as part of the initial defineComponent call: https://github.com/ionic-team/ionic-framework/blob/main/packages/vue/src/components/IonPage.ts#L4 Is it possible to do that here, or is there a blocking difference in how the components are set up? I'm just wary of this line being missed if we have to copy-paste this setup in the future. (Ditto for IonBackButton and IonNav)
There was a problem hiding this comment.
That only applies to non-functional components which were never impacted by this bug. App, BackButton, and Nav are functional components so they don't have access to that "name" field in the object like the other components do.
amandaejohnston
approved these changes
Apr 12, 2023
liamdebeasi
added a commit
that referenced
this pull request
Apr 17, 2023
<!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> <!-- Issues are required for both bug fixes and features. --> Issue URL: resolves #25199 Vue components show up as "Anonymous Component" in Vue Dev Tools. This is caused by our use of `displayName` instead of `name`. This required a fix in the Vue Output Target package. See ionic-team/stencil-ds-output-targets#257 for more info. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updates the Vue Output Target dependency - Functional components created manually in Ionic Vue now set `name` instead of `displayName`. Note: Non-functional components were never impacted by this bug. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.0.2-dev.11681308435.141a05de`
liamdebeasi
added a commit
that referenced
this pull request
Apr 19, 2023
<!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> <!-- Issues are required for both bug fixes and features. --> Issue URL: resolves #25199 Vue components show up as "Anonymous Component" in Vue Dev Tools. This is caused by our use of `displayName` instead of `name`. This required a fix in the Vue Output Target package. See ionic-team/stencil-ds-output-targets#257 for more info. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updates the Vue Output Target dependency - Functional components created manually in Ionic Vue now set `name` instead of `displayName`. Note: Non-functional components were never impacted by this bug. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.0.2-dev.11681308435.141a05de`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Issue URL: resolves #25199
Vue components show up as "Anonymous Component" in Vue Dev Tools. This is caused by our use of
displayNameinstead ofname. This required a fix in the Vue Output Target package. See ionic-team/stencil-ds-output-targets#257 for more info.What is the new behavior?
nameinstead ofdisplayName. Note: Non-functional components were never impacted by this bug.Does this introduce a breaking change?
Other information
Dev build:
7.0.2-dev.11681308435.141a05de