Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] ion-item doesn't get 'activated' when it contains html elements #6192

Closed
biesbjerg opened this issue Apr 16, 2016 · 4 comments
Closed
Milestone

Comments

@biesbjerg
Copy link

biesbjerg commented Apr 16, 2016

Short description of the problem:

ion-item doesn't get class 'activated' on mousedown when it contains html elements.

What behavior are you expecting?

I expected ion-item to get 'activated' (default grey background) when clicked/tapped/mousedown, no matter the contents of ion-item.

Steps to reproduce:

  1. View plunker: http://plnkr.co/edit/L8MJR6xt6Ddcj09q1ZgV?p=preview
  2. Trigger a mousedown event on the text that says "I DON'T WORK" (Text is in an html element)
  3. Trigger a mousedown event on the text that says "I DO WORK" and see that it works (Text is direct child of ion-item)

I've traced down the code that is responsible for added 'activated' class to activatable elements. I will attempt creating a pull request shortly.

Cordova CLI: 6.1.1
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.4
Ionic CLI Version: 2.0.0-beta.24
Ionic App Lib Version: 2.0.0-beta.14
ios-deploy version: 1.8.5
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v4.4.2
Xcode version: Xcode 7.3 Build version 7D175
@biesbjerg biesbjerg changed the title [v2] ion-list doesn't get 'activated' when ion-item contains html elements [v2] ion-item doesn't get 'activated' when it contains html elements Apr 16, 2016
@biesbjerg
Copy link
Author

This also solves #6159 for me regarding the ignored click events, although I can't explain why.

@manucorporat
Copy link
Contributor

@biesbjerg check out my PR: #6205

@adamdbradley
Copy link
Contributor

This should be fixed in the next release from this PR: #6205 Thanks

@adamdbradley adamdbradley added this to the 2.0.0-beta.5 milestone Apr 18, 2016
@turbobuilt
Copy link

This is still not working for me:

Cordova CLI: 6.1.1
Gulp version: CLI version 3.9.1
Gulp local: Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.10
Ionic CLI Version: 2.0.0-beta.35
Ionic App Lib Version: 2.0.0-beta.19
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v6.3.1
Xcode version: Xcode 7.3 Build version 7D175

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants