fix(rtl): enable ltr default, rtl selectors #16987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought RTL styles won't be included by default anymore? An idea would be to put them in an optional CSS file. Sorry if I misunderstood :-) |
|
@abennouna With shadow dom it's proving to be challenging to have an optional css file for RTL, since certain parts of the components would not be able to easily know the Would you be able to pull down this branch and test it out? |
abennouna
reviewed
Jan 8, 2019
abennouna
reviewed
Jan 8, 2019
abennouna
reviewed
Jan 8, 2019
abennouna
reviewed
Jan 8, 2019
core/src/themes/ionic.mixins.scss
Outdated
| } | ||
| -webkit-padding-start: $start; | ||
| padding-inline-start: $start; | ||
| -webkit-padding-end: $end; |
There was a problem hiding this comment.
Suggested change
| -webkit-padding-end: $end; | |
| -webkit-#{$prop}-end: $end; |
Co-Authored-By: adamdbradley <adamdbradley@users.noreply.github.com>
Co-Authored-By: adamdbradley <adamdbradley@users.noreply.github.com>
Co-Authored-By: adamdbradley <adamdbradley@users.noreply.github.com>
Co-Authored-By: adamdbradley <adamdbradley@users.noreply.github.com>
|
i see greate work both of you making here |
This was referenced Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.