Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alert): update styles for rtl #17129

Merged
merged 27 commits into from Jan 16, 2019
Merged

fix(alert): update styles for rtl #17129

merged 27 commits into from Jan 16, 2019

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jan 15, 2019 •
edited

https://screenshot.ionicframework.com/5447404/d8bad6a

references #17012 fixes #16295

test master rtl-fix-alert
buttons (md) buttons-md-master buttons-md-latest
buttons (ios) buttons-ios-master buttons-ios-latest
checkbox (md) checkbox-md-master checkbox-md-latest
checkbox (ios) checkbox-ios-master checkbox-ios-latest
radio (md) radio-md-master radio-md-latest
radio (ios) radio-ios-master radio-ios-latest

adamdbradley and others added 19 commits January 7, 2019 12:21
@adamdbradley
fix(rtl): enable ltr default, rtl selectors
1b5c1d4
@adamdbradley
refactor(rtl): update dir selectors on :host
fbce676
@adamdbradley
refactor(rtl): update add-root-selector sass fn
4912929
@adamdbradley
refactor(rtl): use css logical properties for padding/margin
1533345
@adamdbradley
fix(item-divider): fix padding
9a87355
@adamdbradley
Merge branch 'master' into rtl
60a2ac9
@adamdbradley
test(rtl): add item basic rtl script
2f461a7
@abennouna @adamdbradley
fix(rtl): update core/src/themes/ionic.mixins.scss
3f3057e 
Co-Authored-By: adamdbradley <adamdbradley@users.noreply.github.com>
@abennouna @adamdbradley
fix(rtl): update core/src/themes/ionic.mixins.scss
19cbc75 
Co-Authored-By: adamdbradley <adamdbradley@users.noreply.github.com>
@abennouna @adamdbradley
fix(rtl): update core/src/themes/ionic.mixins.scss
53de8b8 
Co-Authored-By: adamdbradley <adamdbradley@users.noreply.github.com>
@abennouna @adamdbradley
fix(rtl): update core/src/themes/ionic.mixins.scss
d3471e9 
Co-Authored-By: adamdbradley <adamdbradley@users.noreply.github.com>
@adamdbradley
Merge branch 'master' into rtl
ce2e936
@adamdbradley
Merge branch 'master' into rtl
9139393
@adamdbradley
refactor(rtl): wrap css logical props with @supports
c13214b
@adamdbradley
refactor(rtl): do not use css logical properties for hardcoded 0 values
2010a27
@adamdbradley
Merge branch 'master' into rtl
a1e2869
@adamdbradley
Merge branch 'master' into rtl
e8f112d
@adamdbradley
Merge branch 'master' into rtl
d3f214e
@brandyscarney
fix(alert): use the proper borders for the buttons for rtl
92de1b7 
references #17012
@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jan 15, 2019
@brandyscarney brandyscarney mentioned this pull request Jan 15, 2019
Closed
@brandyscarney brandyscarney merged commit ceae5d2 into master Jan 16, 2019
@brandyscarney brandyscarney deleted the rtl-fix-alert branch January 16, 2019 20:39
@ansarikhurshid786
Copy link

ansarikhurshid786 commented Feb 14, 2019 •
edited

I am facing issue.
Device : android
Elelement : ion-select //interface = alert
direction : rtl (arabic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdbradley adamdbradley Awaiting requested review from adamdbradley

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ion Select radio options are hidden in RTL mode
4 participants
@brandyscarney @ansarikhurshid786 @adamdbradley @abennouna