Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(popover): placement per md spec #17429

Merged
merged 4 commits into from Feb 27, 2019
Merged

fix(popover): placement per md spec #17429

merged 4 commits into from Feb 27, 2019

Conversation

daem0ndev
Copy link
Contributor

Short description of what this resolves:

Changes proposed in this pull request:

  • Changes default placement of popover to be below the triggering element, as per MD spec.

Ionic Version: v4

Fixes: #17427

liamdebeasi
liamdebeasi approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉 Thanks for the PR!

@liamdebeasi liamdebeasi merged commit a99d179 into ionic-team:master Feb 27, 2019
@brandyscarney brandyscarney mentioned this pull request Mar 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daem0ndev @liamdebeasi