Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(range): Clamp values that are out of bounds #17623

Merged
merged 3 commits into from Mar 1, 2019
Merged

fix(range): Clamp values that are out of bounds #17623

merged 3 commits into from Mar 1, 2019

Conversation

liamdebeasi
Copy link
Contributor

Short description of what this resolves:

Fixes an issue where programmatically setting the value of a range (via a button click or something) was allowing out of bounds values to be emitted

Changes proposed in this pull request:

  • When emitting values, always check to make sure values are not out of bounds, and clamp if appropriate
  • Added tests to verify fix

Ionic Version:

Fixes: #17566

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Feb 26, 2019
@liamdebeasi liamdebeasi marked this pull request as ready for review February 26, 2019 21:24
@liamdebeasi liamdebeasi merged commit 5a197ca into master Mar 1, 2019
@liamdebeasi liamdebeasi deleted the fix-range-out-of-bounds branch March 1, 2019 17:25
@liamdebeasi liamdebeasi mentioned this pull request Mar 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liamdebeasi @brandyscarney