Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range): Clamp values that are out of bounds #17623

Merged
merged 3 commits into from Mar 1, 2019

Conversation

Projects
None yet
2 participants
@liamdebeasi
Copy link
Member

commented Feb 26, 2019

Short description of what this resolves:

Fixes an issue where programmatically setting the value of a range (via a button click or something) was allowing out of bounds values to be emitted

Changes proposed in this pull request:

  • When emitting values, always check to make sure values are not out of bounds, and clamp if appropriate
  • Added tests to verify fix

Ionic Version:

Fixes: #17566

liamdebeasi added some commits Feb 26, 2019

@liamdebeasi liamdebeasi marked this pull request as ready for review Feb 26, 2019

@liamdebeasi liamdebeasi requested a review from brandyscarney Mar 1, 2019

@liamdebeasi liamdebeasi merged commit 5a197ca into master Mar 1, 2019

1 check passed

build Workflow: build
Details

@liamdebeasi liamdebeasi deleted the fix-range-out-of-bounds branch Mar 1, 2019

KillerCodeMonkey added a commit to KillerCodeMonkey/ionic that referenced this pull request Mar 1, 2019

fix(range): clamp values that are out of bounds (ionic-team#17623)
* fix(range): clamp out of bounds values, add tests

* lint files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.