Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): account for larger tablets #17630

Merged
merged 13 commits into from Mar 15, 2019

Conversation

2 participants
@liamdebeasi
Copy link
Member

commented Feb 27, 2019

Short description of what this resolves:

This PR fixes an issue where platform.is('tablet') would return false for larger tablets such as the iPad Pro and the Galaxy View.

Note: There are still edge cases this PR misses, but the purpose of this PR is to bring support to some of the more common platforms (large iOS and Android tablets, specifically). I think the ideal fix requires some re-thinking of how we do platform detection, so I've created a feature request for it here: #17631

Changes proposed in this pull request:

  • Add additional checks to isTablet to see if platform is iPad or Android tablet. Fall back to old detection method if not.

Ionic Version:

Fixes: #15434

@liamdebeasi liamdebeasi marked this pull request as ready for review Feb 27, 2019

liamdebeasi added some commits Feb 27, 2019

@liamdebeasi liamdebeasi requested a review from brandyscarney Mar 1, 2019

@brandyscarney

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

Going to tag @adamdbradley for review on this one as I know there were some issues with tablet sizes before.

@brandyscarney brandyscarney requested a review from adamdbradley Mar 1, 2019

@brandyscarney brandyscarney added this to In progress 🤺 in Ionic Core via automation Mar 4, 2019

@brandyscarney brandyscarney moved this from In progress 🤺 to Needs review 🤔 in Ionic Core Mar 4, 2019

@brandyscarney brandyscarney moved this from Needs review 🤔 to On deck ⚾️ in Ionic Core Mar 7, 2019

liamdebeasi added some commits Mar 11, 2019

@liamdebeasi liamdebeasi moved this from On deck ⚾️ to Needs review 🤔 in Ionic Core Mar 14, 2019

liamdebeasi added some commits Mar 15, 2019

@liamdebeasi liamdebeasi merged commit 29dbd07 into master Mar 15, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

Ionic Core automation moved this from Needs review 🤔 to Done 🎉 Mar 15, 2019

@liamdebeasi liamdebeasi deleted the platform branch Mar 15, 2019

santoshyadav198613 added a commit to santoshyadav198613/ionic that referenced this pull request Mar 16, 2019

fix(platform): account for larger tablets (ionic-team#17630)
* fix(platform): account for larger tablets

* lint files

* add utils file, clean up tests, add more tests

* update tests with extra desktop checks

* change window to win

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

fix(platform): account for larger tablets (ionic-team#17630)
* fix(platform): account for larger tablets

* lint files

* add utils file, clean up tests, add more tests

* update tests with extra desktop checks

* change window to win
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.