fix(platform): account for larger tablets #17630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to tag @adamdbradley for review on this one as I know there were some issues with tablet sizes before. |
…latform merfge
kiku-jw
pushed a commit
to kiku-jw/ionic
that referenced
this pull request
May 16, 2019
* fix(platform): account for larger tablets * lint files * add utils file, clean up tests, add more tests * update tests with extra desktop checks * change window to win
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This PR fixes an issue where
platform.is('tablet')would returnfalsefor larger tablets such as the iPad Pro and the Galaxy View.Note: There are still edge cases this PR misses, but the purpose of this PR is to bring support to some of the more common platforms (large iOS and Android tablets, specifically). I think the ideal fix requires some re-thinking of how we do platform detection, so I've created a feature request for it here: #17631
Changes proposed in this pull request:
isTabletto see if platform is iPad or Android tablet. Fall back to old detection method if not.Ionic Version:
Fixes: #15434