fix(reorder-group): should be able to reorder items from within a sha… #17747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dow dom component Resolves: ionic-team#17746
|
Hi there, Thanks for the PR! Would you be able to add some tests that verify this functionality? Thanks! |
|
Sure, I'll give it a shot. I just added a standard interactive test. I'll add onto that to verify this functionality shortly. |
|
@liamdebeasi All set - let me know if you have any questions or concerns. Thanks! |
|
Thanks for the PR! The fix looks good to me. 🙂 @liamdebeasi Could you review the tests? |
brandyscarney
approved these changes
Mar 26, 2019
|
Hey there, I pushed a few updates to your branch regarding the tests:
Going to do another quick look over, but everything else looks really great! Nice work! 🎉 |
|
Merged 🎉 |
kiku-jw
pushed a commit
to kiku-jw/ionic
that referenced
this pull request
May 16, 2019
…-team#17747) - adds ability to reorder items from within a shadow dom component - adds interactive test fixes ionic-team#17746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Changes proposed in this pull request:
this.elinstead ofthis.doc.bodyIonic Version: 4.1.1
Fixes: #17746