Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Fixed popover controller #17865

Merged
merged 2 commits into from Mar 25, 2019

Conversation

Projects
None yet
2 participants
@lherman-cs
Copy link
Contributor

commented Mar 22, 2019

Short description of what this resolves:

This PR fixed a typo in the popover controller, https://github.com/ionic-team/ionic/blob/master/vue/src/controllers/popover-controller.ts#L5.

before:

export const CTRL = 'ion-modal-controller';

Changes proposed in this pull request:

  • Change the typo line to be:
export const CTRL = 'ion-popover-controller'

Ionic Version: 4.1.2

Fixes: #17864

@ionitron-bot ionitron-bot bot added the package: vue label Mar 22, 2019

@mhartington mhartington merged commit 0cb7db0 into ionic-team:master Mar 25, 2019

1 check passed

build Workflow: build
Details

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.