Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item-sliding): hide opposite side options #17986

Merged

Conversation

Projects
None yet
3 participants
@masimplo
Copy link
Contributor

commented Apr 6, 2019

Short description of what this resolves:

This resolves an issue where both ion-item-options are show when sliding an ion-item-sliding item.

Changes proposed in this pull request:

  • adds a css rule to hide the opposite item-options when sliding item is open
  • adds an item in basic tests to demonstrate the issue and fix

Ionic Version:

Fixes: #17822

Video demonstrating issue and fix:
video

@masimplo masimplo force-pushed the masimplo:fix-sliding-buttons-visibility branch from 3471ad8 to f7e983d Apr 6, 2019

@liamdebeasi
Copy link
Member

left a comment

Hey there,

Thanks for the PR -- this is looking great!

One small thing I'm noticing is if you drag an item-sliding all the way over to one side, you can see the last bit of one of the buttons (if there are multiple):

Screen Shot 2019-04-11 at 11 51 51 AM

If you change the 90% in item-sliding/item-sliding.scss:36 and item-sliding/item-sliding.scss:54 to 100% that should fix the issue.

liamdebeasi and others added some commits Apr 11, 2019

@masimplo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

Hi,
thanks for looking into this. You are correct, it was a bit tricky to reproduce as it does not happen in the emulator but on desktop. Nice catch!
Just pushed the proposed fix, which works like a charm.

@liamdebeasi
Copy link
Member

left a comment

Great job! 🎉

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Hey there! Per @brandyscarney's comment #17822 (comment) I've updated the CSS a little bit to fix the issue. Looks like the visibility: hidden got removed during our v3->v4 transfer, so I added it back.

@brandyscarney brandyscarney self-requested a review Apr 11, 2019

liamdebeasi added some commits Apr 15, 2019

@liamdebeasi liamdebeasi merged commit f13722c into ionic-team:master Apr 15, 2019

1 check passed

build Workflow: build
Details
@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Merged. Thank you! 🎉

@masimplo masimplo deleted the masimplo:fix-sliding-buttons-visibility branch Apr 16, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

fix(item-sliding): hide opposite side options when other side is open (
…ionic-team#17986)

* fix(item-sliding): hide opposite side options

* Fix padding issue

* add visibility hidden for item options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.