Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(segment): default ripple to currentColor #18547

Merged
merged 4 commits into from Jun 21, 2019
Merged

Conversation

brandyscarney
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

First way to reproduce

  1. Go to the following test on master: http://localhost:3333/src/components/segment/test/toolbar
  2. Click the second segment, and notice the ripple isn't visible.
  3. Repeat on branch to see it fixed

Second way to reproduce

  1. Go to the following test on master in full screen mode: http://localhost:3333/src/themes/test/css-variables
  2. Click on the "dark" theme from the select in the upper right
  3. Click on the segment in the toolbar, see that the ripple background is blue
  4. Repeat on branch to see it fixed

Issue Number: N/A

What is the new behavior?

Updates the ripple-color to use currentColor, this fixes an issue with themed toolbars so that it doesn't use the default (primary) color.

Does this introduce a breaking change?

  • Yes
  • No

Other information

this fixes an issue with themed toolbars so that it doesn't use the default primary color
@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jun 14, 2019
@brandyscarney brandyscarney merged commit 832306c into master Jun 21, 2019
@brandyscarney brandyscarney deleted the fix-segment-ripple branch June 21, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant