Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(back-button): convert to shadow #19411

Merged
merged 6 commits into from Nov 14, 2019
Merged

refactor(back-button): convert to shadow #19411

merged 6 commits into from Nov 14, 2019

Conversation

adamdbradley
Copy link
Contributor

@adamdbradley adamdbradley commented Sep 20, 2019 •
edited by liamdebeasi

references #18899

Dev 5.0.0-dev.201911141851.1494377

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Sep 20, 2019
@adamdbradley adamdbradley added this to the Next milestone Sep 20, 2019
@brandyscarney
Copy link
Member

Is this ready for review? It looks like it.

@brandyscarney brandyscarney marked this pull request as ready for review November 13, 2019 18:27
@brandyscarney brandyscarney mentioned this pull request Nov 13, 2019
Closed
@liamdebeasi liamdebeasi merged commit 0d40d3f into master Nov 14, 2019
@liamdebeasi liamdebeasi deleted the back-button-shadow branch December 5, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamdbradley @brandyscarney @liamdebeasi