Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(searchbar): update padding and button alignment #19532

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@brandyscarney
Copy link
Member

commented Oct 2, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Buttons were not aligned next to a searchbar due to the padding-top of the searchbar decreasing.

Issue Number: fixes #19502

What is the new behavior?

Buttons are now aligned vertically and horizontally as if the searchbar was not there.

master branch
localhost_3333_src_components_searchbar_test_toolbar(iPhone 6_7_8) (2) localhost_3333_src_components_searchbar_test_toolbar(iPhone 6_7_8) (1)

Does this introduce a breaking change?

  • Yes
  • No

Other information

@brandyscarney brandyscarney force-pushed the fix-searchbar-buttons branch from b29d66e to c3cd670 Oct 2, 2019
@brandyscarney brandyscarney changed the base branch from release-4.10.1 to master Oct 2, 2019
@brandyscarney brandyscarney force-pushed the fix-searchbar-buttons branch from c3cd670 to 4d57ccf Oct 2, 2019
@brandyscarney brandyscarney changed the title Fix searchbar buttons fix(searchbar): update padding and button alignment Oct 2, 2019
@brandyscarney brandyscarney added this to In progress 🤺 in Ionic Core via automation Oct 2, 2019
@brandyscarney brandyscarney moved this from In progress 🤺 to Needs review 🤔 in Ionic Core Oct 2, 2019
@brandyscarney brandyscarney requested a review from liamdebeasi Oct 2, 2019
@brandyscarney brandyscarney merged commit 77658e6 into master Oct 2, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
Ionic Core automation moved this from Needs review 🤔 to Done 🎉 Oct 2, 2019
@brandyscarney brandyscarney deleted the fix-searchbar-buttons branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ionic Core
  
Done 🎉
1 participant
You can’t perform that action at this time.