Skip to content

Commit

Permalink
chore!: support only node 16+ (#354)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: drop node 10-14 support
  • Loading branch information
jcesarmobile committed Oct 25, 2023
1 parent bf94440 commit eb20983
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Expand Up @@ -20,10 +20,9 @@ jobs:
strategy:
matrix:
node:
- 20.x
- 18.x
- 16.x
- 14.x
- 12.x
steps:
- uses: actions/setup-node@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -18,7 +18,7 @@ To install, run:
npm install -g native-run
```

:memo: Requires NodeJS 10+
:memo: Requires NodeJS 16+

## Usage

Expand Down
4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -25,7 +25,7 @@
"dist"
],
"engines": {
"node": ">=12.13.0"
"node": ">=16.0.0"
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -54,7 +54,7 @@
"@types/elementtree": "^0.1.1",
"@types/ini": "^1.3.31",
"@types/jest": "^26.0.13",
"@types/node": "^10.17.14",
"@types/node": "^16.0.0",
"@types/plist": "^3.0.2",
"@types/split2": "^3.2.1",
"@types/through2": "^2.0.34",
Expand Down
2 changes: 1 addition & 1 deletion src/android/utils/emulator.ts
Expand Up @@ -128,7 +128,7 @@ export async function spawnEmulator(
p.on('close', code => {
debug('Emulator closed, exit code %d', code);

if (code > 0) {
if (code) {
reject(
new EmulatorException(
`Non-zero exit code from Emulator: ${code}`,
Expand Down

0 comments on commit eb20983

Please sign in to comment.