Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: support only node 16+ #354

Merged
merged 3 commits into from
Oct 25, 2023
Merged

chore!: support only node 16+ #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19ab2e4
chore!: support only node 16+
jcesarmobile Oct 24, 2023
8d54a95
Merge branch 'develop' into node-16
jcesarmobile Oct 25, 2023
137388d
Merge branch 'develop' into node-16
jcesarmobile Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,9 @@ jobs:
strategy:
matrix:
node:
- 20.x
- 18.x
- 16.x
- 14.x
- 12.x
steps:
- uses: actions/setup-node@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ To install, run:
npm install -g native-run
```

:memo: Requires NodeJS 10+
:memo: Requires NodeJS 16+

## Usage

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"dist"
],
"engines": {
"node": ">=12.13.0"
"node": ">=16.0.0"
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -54,7 +54,7 @@
"@types/elementtree": "^0.1.1",
"@types/ini": "^1.3.31",
"@types/jest": "^26.0.13",
"@types/node": "^10.17.14",
"@types/node": "^16.0.0",
"@types/plist": "^3.0.2",
"@types/split2": "^3.2.1",
"@types/through2": "^2.0.34",
Expand Down
2 changes: 1 addition & 1 deletion src/android/utils/emulator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export async function spawnEmulator(
p.on('close', code => {
debug('Emulator closed, exit code %d', code);

if (code > 0) {
if (code) {
reject(
new EmulatorException(
`Non-zero exit code from Emulator: ${code}`,
Expand Down